Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: solvent accessible surface area (SASA) #10

Open
f3rmion opened this issue Mar 4, 2021 · 4 comments
Open

Feature request: solvent accessible surface area (SASA) #10

f3rmion opened this issue Mar 4, 2021 · 4 comments
Labels
FR Feature request wontfix This will not be worked on

Comments

@f3rmion
Copy link
Member

f3rmion commented Mar 4, 2021

Describe the solution you'd like
Implement solvent accessible surface area (SASA) using an angular Lebedev-Laikov grid as described in "A quadrature formula for the sphere of the 131st algebraic order of accuracy", Doklady Mathematics, Vol. 59, No. 3, 1999, pp. 477-481.
Extend present grid implementation in src/grid.py to cover finer grids and use the defined gridpoints to construct a SASA.

@awvwgk
Copy link

awvwgk commented Mar 4, 2021

Note that most Lebedev-Laikov grid implementations carry either the LGPL (inherited from J. Burkardt's version) or originate from the CCL announcement of the original implementation of D. Laikov, which has somewhat unclear licensing conditions but might be considered public domain (?).

@f3rmion
Copy link
Member Author

f3rmion commented Mar 4, 2021

Note that most Lebedev-Laikov grid implementations carry either the LGPL (inherited from J. Burkardt's version) or originate from the CCL announcement of the original implementation of D. Laikov, which has somewhat unclear licensing conditions but might be considered public domain (?).

That's right, using Burkardt's version would force an LGPL license on the project. Laikov's original version does not seem to be properly licensed, especially since the linked Fortran version was not implemented by Laikov himself, but rather by Christoph van Wuellen depending on an initial C-version written by Laikov.

@awvwgk
Copy link

awvwgk commented Mar 4, 2021

My xtb and DFTB+ implementation of the grids are based on J. Burkhardt's version due to the clearer and compatible licensing.

Every other implementation (C, Matlab, Python, ...) I have been able to find so far at some point goes back to J. Burkhardt's version or C. van Wuellen's version of the C implementation by D. Laikov. The original C code seems to be lost, at least I wasn't able to find it up to now.

@f3rmion f3rmion added the enhancement New feature or request label Mar 7, 2021
@Montana
Copy link

Montana commented May 5, 2021

Thank you @awvwgk!

@f3rmion f3rmion added FR Feature request and removed enhancement New feature or request labels Jul 26, 2021
@f3rmion f3rmion added the wontfix This will not be worked on label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR Feature request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants