Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for signature validation for GetJWSDomain API Response #30

Open
mcieplak opened this issue Mar 20, 2021 · 0 comments
Open
Labels
enhancement New feature or request HackTogether For Yahoo Hack Together event

Comments

@mcieplak
Copy link
Contributor

mcieplak commented Mar 20, 2021

Please describe the problem that you are trying to solve
After making the GetJWSDomain call to ZMS, the Athenz Syncer should verify the signature of the response before using the domain contents.

Describe the solution you'd like
When the Athenz Syncer is making requests to the GetJWSDomain API, it should verify the signature of the response before setting the Athenz Domain Status field. A sample JWS domain object is shown below.

{
  "payload": "Zm9vYmFyCg==.....",
  "header": {
    "keyid": "zms.key.3.0"
  },
  "signature": "YmFyZm9vCg==...",
  "protected": "YmFyCg==..."
}

As can be seen above, the object consists of the payload, signature, keyid, and the protected fields. Before we can cast the payload into a domain object, we must verify the payload using the keyid specified. The steps are shown below.

  1. Use the Athenz ZMS client GetPublicKeyEntry function to fetch the keyid specified.
  2. Use the zmssvctoken ybase64 DecodeString functionality to decode the key response.
  3. Use a jws library to verify the payload against the signature field using the public key fetched from ZMS.

Additional context
More context can be found in the previous issue which is also a prerequisite to complete this one.

@mcieplak mcieplak added enhancement New feature or request HackTogether For Yahoo Hack Together event labels Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request HackTogether For Yahoo Hack Together event
Projects
None yet
Development

No branches or pull requests

1 participant