Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throwing between in GC programs is annoying #66

Open
3 tasks
p0nce opened this issue Dec 28, 2023 · 0 comments
Open
3 tasks

Throwing between in GC programs is annoying #66

p0nce opened this issue Dec 28, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@p0nce
Copy link
Collaborator

p0nce commented Dec 28, 2023

Simplify these patterns:

if (!img.isValid)
    throw new Exception(img.errorMessage().idup);

Also this pattern is wrong! No error message on saving files.

if (!image.saveToFile("path.ext"))
    throw new Exception(img.errorMessage().idup);
  • Should failed save should put the image in errored state?
  • Helper function for first pattern
  • Decide what to do for last pattern
@p0nce p0nce added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant