Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Greatcoats #20037

Merged
merged 7 commits into from
Oct 19, 2024
Merged

Adds Greatcoats #20037

merged 7 commits into from
Oct 19, 2024
+98 −1

Conversation

Ben10083
Copy link
Contributor

@Ben10083 Ben10083 commented Oct 11, 2024 •
edited
Loading

Adds Black and Brown Greatcoats to loadout, thanks to greytide_(discord) for sprites!

Black:
image
image

Brown:
image
image

  • Description
  • Open Sprites

@BotBOREALIS BotBOREALIS added Sprites Adds new or changes existing sprites. WIP The PR is a work in progress and should not be reviewed yet. labels Oct 11, 2024
@BotBOREALIS BotBOREALIS added Review Required and removed WIP The PR is a work in progress and should not be reviewed yet. labels Oct 14, 2024
FluffyGhoster
FluffyGhoster approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@FluffyGhoster FluffyGhoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine enough code wise

@1glitchycent
Copy link

zavodbros.... we won???!!!

@NonQueueingMatt NonQueueingMatt added the ⛔ Maintainer Discussion The PR will be discussed by the maintainers. label Oct 15, 2024
@NonQueueingMatt
Copy link
Contributor

applying maint discussion because I'm leaning towards not allowing greatcoats for non-Dominians for setting consistency

@NonQueueingMatt NonQueueingMatt removed the ⛔ Maintainer Discussion The PR will be discussed by the maintainers. label Oct 18, 2024
@NonQueueingMatt
Copy link
Contributor

add the new sprites you showed in code dungeon without the lining and this is fine to merge

@Ben10083 Ben10083 changed the title Adds Zavodskoi Greatcoats Adds Greatcoats Oct 18, 2024
@Ben10083
Copy link
Contributor Author

@NonQueueingMatt Added. PR changed to reflect that these are now Black and Brown greatcoats, added new loadout option for them

@NonQueueingMatt NonQueueingMatt added this pull request to the merge queue Oct 19, 2024
Merged via the queue into Aurorastation:master with commit 84d135d Oct 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NonQueueingMatt NonQueueingMatt NonQueueingMatt approved these changes

@FluffyGhoster FluffyGhoster FluffyGhoster approved these changes

@Arrow768 Arrow768 Awaiting requested review from Arrow768 Arrow768 is a code owner

@alsoandanswer alsoandanswer Awaiting requested review from alsoandanswer alsoandanswer is a code owner

Assignees
No one assigned
Labels
Awaiting Merge Sprites Adds new or changes existing sprites.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ben10083 @1glitchycent @NonQueueingMatt @FluffyGhoster @BotBOREALIS