Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluespace drive #20053

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

FluffyGhoster
Copy link
Contributor

immagine

Added the bluespace drive.
Fixed overmap projectiles not transferring correctly.
Code improvements. A lot of.

@BotBOREALIS BotBOREALIS added the Sprites Adds new or changes existing sprites. label Oct 14, 2024
@github-actions github-actions bot added 🗺️ Mapping - Horizon The PR touches the Horizon map files. TGUI labels Oct 14, 2024
@courierbravo
Copy link
Contributor

Internal walls are using cardinal ship walls. Internal walls, outside of rare use cases like burn chambers, should be using /turf/simulated/wall and /turf/simulated/wall/r_wall, the standard steel and reinforced walls.
Likewise with windows, they should be using the normal window frame spawners, not the hull spawners.
There's a lightswitch directly on the window. It should be on a solid wall, not the windowframe/glass.
image

@courierbravo
Copy link
Contributor

The ceiling above has no plating covering it, leaving it exposed.
The area above will need to be edited partially to accommodate for the new floor.
image

@courierbravo
Copy link
Contributor

The room is cramped and lacking adequate detailing.
Please replace the floor under the equipment with bare plate or some similar change (see: supermatter and INDRA)
Please also expand the area, so that engineers can safely work in the room and make modifications.
image

@courierbravo
Copy link
Contributor

While technically passable, this room needs at least one more set of vents/scrubbers. Additionally, the pipes shouldn't be crossing over each other. See guidelines_atmos_pipes.dmi for examples of proper piping.
image

@courierbravo
Copy link
Contributor

Please rewire it from feeding off of the engineering sublevel grid to directly off the main grid.
Additionally, since its on its own SMES network, the room should have its own powernet sensor and breakers.
image

@courierbravo
Copy link
Contributor

The drive being a box jutting out the side of the ship doesn't look good. I strongly recommend consulting the mapping team on how we can remap a portion of the maints area there and even that whole side of deck 1 engineering to properly incorporate this.
image

Copy link
Contributor

@courierbravo courierbravo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a mapping perspective, this needs a good bit of work still. Issues detailed.

@FluffyGhoster
Copy link
Contributor Author

Internal walls are using cardinal ship walls. Internal walls, outside of rare use cases like burn chambers, should be using /turf/simulated/wall and /turf/simulated/wall/r_wall, the standard steel and reinforced walls. Likewise with windows, they should be using the normal window frame spawners, not the hull spawners. There's a lightswitch directly on the window. It should be on a solid wall, not the windowframe/glass.

Fixed

The ceiling above has no plating covering it, leaving it exposed.
The area above will need to be edited partially to accommodate for the new floor.

Fixed

The room is cramped and lacking adequate detailing.
Please replace the floor under the equipment with bare plate or some similar change (see: supermatter and INDRA)
Please also expand the area, so that engineers can safely work in the room and make modifications.

Disagree

While technically passable, this room needs at least one more set of vents/scrubbers. Additionally, the pipes shouldn't be crossing over each other. See guidelines_atmos_pipes.dmi for examples of proper piping.

Implemented

Please rewire it from feeding off of the engineering sublevel grid to directly off the main grid.
Additionally, since its on its own SMES network, the room should have its own powernet sensor and breakers.

They aren't connected in cascade, they both feed from the same wire

The drive being a box jutting out the side of the ship doesn't look good. I strongly recommend consulting the mapping team on how we can remap a portion of the maints area there and even that whole side of deck 1 engineering to properly incorporate this.

Not meaningfully different than the other "boxes" that jut out of the side of the ship, eg. the science firing range

@courierbravo
Copy link
Contributor

The amount of atmos int the room isnt acceptable. Especially for a room handling gases like phoron.
The SMES's still need to be being fed from the main power line (red cable)
The firing range has detailing around it, along with fitting neatly under the ship. Where as the bluespace drive is jutting out from the side of the ship, visible from z layers above it.
Going to communicate further over discord as required.

@FluffyGhoster FluffyGhoster linked an issue Oct 15, 2024 that may be closed by this pull request
1 task
courierbravo and others added 8 commits October 17, 2024 06:57
@FluffyGhoster FluffyGhoster linked an issue Oct 17, 2024 that may be closed by this pull request
1 task
@FluffyGhoster
Copy link
Contributor Author

!review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ Mapping - Horizon The PR touches the Horizon map files. Review Required Sprites Adds new or changes existing sprites. TGUI
Projects
None yet
3 participants