Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Good practices for test coding idioms #105

Open
prasadtalasila opened this issue Nov 18, 2018 · 2 comments
Open

Good practices for test coding idioms #105

prasadtalasila opened this issue Nov 18, 2018 · 2 comments

Comments

@prasadtalasila
Copy link
Member

Description

Look for coding idioms of Mocha and Cucumber in ES6 code base. The ideal ESLint rules for test directory should satisfy top-down rule and understand the the context of the test cases.

Steps to Reproduce

Expected behavior: [What you expect to happen]

Actual behavior: [What actually happens]

Reproduces how often: [What percentage of the time does it reproduce?]

Additional Information
@prasadtalasila
Copy link
Member Author

@mukkachaitanya You have already integrated eslint-plugin-mocha. I guess the changes done in unit and integration tests reflect it already.

The only pending change is the implementation of this idea in feature tests.

@mukkachaitanya mukkachaitanya mentioned this issue Dec 8, 2018
Closed
@prasadtalasila
Copy link
Member Author

PR #113 solves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@prasadtalasila