Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: base_fee solidity computation #9804

Open
LHerskind opened this issue Nov 7, 2024 · 1 comment · May be fixed by #9651 or #9986
Open

feat: base_fee solidity computation #9804

LHerskind opened this issue Nov 7, 2024 · 1 comment · May be fixed by #9651 or #9986
Assignees
@LHerskind
Labels
C-l1-contracts Component: contracts deployed to L1

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Nov 7, 2024 •
edited
Loading

Implement the same computaiton for the base_fee as done in the python notebook.

I believe creating a small library can be useful for it. Testing can be made very convenient since we already have a base implementation in python which was found acceptable and we can simple take the the input/output combinations from it and ensure that the same is computed here.
@LHerskind LHerskind self-assigned this Nov 7, 2024
@LHerskind LHerskind changed the title feat(L1): compute base_fee feat(L1): compute base_fee library Nov 7, 2024
@LHerskind LHerskind changed the title feat(L1): compute base_fee library feat: compute base_fee library Nov 7, 2024
@LHerskind LHerskind changed the title feat: compute base_fee library feat: compute base_fee on L1 Nov 7, 2024
@LHerskind LHerskind added the C-l1-contracts Component: contracts deployed to L1 label Nov 7, 2024
@LHerskind LHerskind mentioned this issue Nov 12, 2024
Merged
@LHerskind
Copy link
Contributor Author

Until #9716 is in, we can "cheat" slightly, by adding it to the header but just have the value be 0. That way, we can run e2e and other tests as they are now, but showcase with L1 that the thing will work when the value is propagated throughout.

LHerskind added a commit that referenced this issue Nov 13, 2024
@LHerskind
feat: multiplier oracle (#9902)
6456ec9 
Fixes #9718. Implements the oracles relying directly on the
`fake_exponential` e,g., the proving cost and fee asset cost.

Using the data generated from
AztecProtocol/engineering-designs#38 and checks
that the solidity implementation matches the values from the python.

The `MinimalFeeModel` showcase the storage needed and computations, the
same logic logic will end up living closer to the rollup contract in
what #9804
@AztecBot AztecBot linked a pull request Nov 13, 2024 that will close this issue
Open
stevenplatt pushed a commit that referenced this issue Nov 13, 2024
@LHerskind @stevenplatt
feat: multiplier oracle (#9902)
f1aca1b 
Fixes #9718. Implements the oracles relying directly on the
`fake_exponential` e,g., the proving cost and fee asset cost.

Using the data generated from
AztecProtocol/engineering-designs#38 and checks
that the solidity implementation matches the values from the python.

The `MinimalFeeModel` showcase the storage needed and computations, the
same logic logic will end up living closer to the rollup contract in
what #9804
@LHerskind LHerskind changed the title feat: compute base_fee on L1 feat: base_fee solidity computation Nov 14, 2024
This was referenced Nov 14, 2024
Open
Open
@LHerskind LHerskind linked a pull request Nov 15, 2024 that will close this issue
feat: compute base-fee on l1 #9986
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LHerskind LHerskind

Labels
C-l1-contracts Component: contracts deployed to L1
Projects
None yet
Milestone
No milestone
1 participant
@LHerskind