Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance Criteria Checklist (DoD) #320

Open
17 of 25 tasks
anfibiacreativa opened this issue May 14, 2024 · 5 comments
Open
17 of 25 tasks

Acceptance Criteria Checklist (DoD) #320

anfibiacreativa opened this issue May 14, 2024 · 5 comments
Assignees

Comments

@anfibiacreativa
Copy link
Member

anfibiacreativa commented May 14, 2024

The following checklist must be complete before a template is published.

Repository Management

Source code structure and conventions

  • GitHub Actions (This refers to .github/workflows/azure-dev.yml or custom workflow to run on a GitHub runner) is in place
  • DevContainer (/.devcontainer folder where applicable) configuration is in place
  • Infrastructure as code is in place (/infra folder where applicable, manifest files or code generators in the case of Aspire and similar )
  • Azure services configuration (/azure.yml file) is in place
  • Minimum coverage tests are in place

Functional requirements

  • azd up successfully provisions and deploys a functional app
  • GitHub Actions run tasks without errors
  • DevContainer has been tested locally and runs
  • Codespaces run [locally and in browser]
  • All tests pass

In the absence of e2e tests,

  • The application has been manually tested to work as per the requirement

Security requirements

When a service selected doesn't support Managed Identity, the corresponding issue must have been reported and the security considerations section in the readme, should clearly explain the alternatives.

  • Azure Key Vault is a preferred alternative

The following items are not strictly enforced but may prevent the template from being added to the gallery.

Project code follows standard structure, per language. Please check one.

  • Yes, follows standards
  • No, doesn't follow standards

Code follows recommended style guide

  • Yes, follows style guide
  • No, doesn't follow style guide
@anfibiacreativa
Copy link
Member Author

@luisquintanilla Please review the pending items or assign to corresponding contributor to help close the issue. Thank you!

@luisquintanilla
Copy link
Collaborator

@LittleLittleCloud can you please take a look when you get a chance. Thanks!

@LittleLittleCloud
Copy link
Collaborator

@anfibiacreativa The secruity guideline link is broken, can you fix that

@anfibiacreativa
Copy link
Member Author

@anfibiacreativa The secruity guideline link is broken, can you fix that

Hi. That's because it is not in place. It should be added to the root.

@LittleLittleCloud
Copy link
Collaborator

LittleLittleCloud commented May 15, 2024

@anfibiacreativa I'm refering to this link. which gives me a 404...

Would you share an example of SECURITY.MD that I can added to the repo

image

@jmatthiesen jmatthiesen added this to the 2024-September milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants