-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Module Proposal]: avm/res/azure-stack-hci/cluster
#929
Comments
avm/res/azurestackhci-clusters
avm/res/azure-stack-hci/clusters
avm/res/azure-stack-hci/clusters
avm/res/azure-stack-hci/cluster
Hi @mbrat2005, Thanks for requesting/proposing to be an AVM module owner! We just want to confirm you agree to the below pages that define what module ownership means: Any questions or clarifications needed, let us know! If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍): "I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER" Thanks, The AVM Core Team #RR |
I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER |
Hi @mbrat2005, Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities! Before starting development, please ensure ALL the following requirements are met. Please use the following values explicitly as provided in the module index page:
Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍 You can now start the development of this module! ✅ Happy coding! 🎉 Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏 Any further questions or clarifications needed, let us know! Thanks, The AVM Core Team |
Working on a bicep template to deploy the prereqs for an Azure Stack HCI cluster running in Azure to enable a testing pipeline. Once completed, I will prioritize the #929 module before moving to Arc VM related modules |
Hi @matebarabas - I'm continuing work on this module and have a testing pipeline completed. For the testing pipeline, the prereq deployment is complex and I'd like to avoid maintaining multiple copies of the same code for each test and other related modules with the same prereqs. Right now, I am throwing them under ./tests/modules. https://github.com/mbrat2005/bicep-registry-modules/tree/mtb-azure-stack-hci-cluster/avm/res/azure-stack-hci/cluster/tests Do you have thoughts on how I might implement reuse here and meet the spec? One thought would be publish the prereqs as a separate pattern module, but the public value (at least for parts) may be limited. Is there somewhere else I could publish and maintain this? |
Thanks for the update, @mbrat2005! I'd like to ask the @Azure/avm-core-team-technical-bicep to comment on your question on how a solution deploying prerequisites could be best reused across multiple modules. |
Poking around, maybe that is the intent of this directory? avm\utilities\e2e-template-assets\templates
…________________________________
|
This is blocked by #1029 |
No longer blocked by underscores in property names, but waiting on Azure/PSRule.Rules.Azure#2966 in release 1.38.0 of PSRule.Rules.Azure |
No longer blocked by #1029 Blocked by the ability to include secrets in the AVM E2E pipelines... see https://teams.microsoft.com/l/message/19:[email protected]/1719241932034?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=f07f871f-f252-4b20-b9ef-9a4ecfdc14f1&parentMessageId=1719241932034&teamName=Azure%20Verified%20Modules&channelName=Bicep%20specific%20discussion&createdTime=1719241932034 |
Blocked by: Azure/bicep-registry-modules#3101 |
Unblocked now that customer CI secret solution is merged |
Important @mbrat2005, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module. Tip To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label. |
Check for previous/existing GitHub issues/module proposals
Check this module doesn't already exist in the module indexes
Bicep or Terraform?
Bicep
Module Classification?
Resource Module
Module Name
avm/res/azure-stack-hci/cluster
Module Details
Azure Stack HCI Cluster resource
Deriving from https://github.com/Azure/azure-quickstart-templates/tree/master/quickstarts/microsoft.azurestackhci/create-cluster-with-prereqs
Do you want to be the owner of this module?
Yes
Module Owner's GitHub Username (handle)
mbrat2005
(Optional) Secondary Module Owner's GitHub Username (handle)
steveswalwell
The text was updated successfully, but these errors were encountered: