Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update azure-vnet directory permissions #2819

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

QxBytes
Copy link
Contributor

@QxBytes QxBytes commented Jun 26, 2024

Reason for Change:

Address race issue in 1.6.x
Now it should not matter if cni or k8s makes the directory since they should both have 0755 permissions.

Issue Fixed:

#2818

Requirements:

Notes:
Created nodesubnet/legacy cluster (no cns), checked var/run/azure-vnet directory and it has 0644 permissions.
Replaced cni version with this new one and restarted the node. The var/run/azure-vnet directory now has 0755 permissions after the reboot.

@QxBytes QxBytes added cni Related to CNI. fix Fixes something. needs-backport Change needs to be backported to previous release trains labels Jun 26, 2024
@QxBytes QxBytes marked this pull request as ready for review June 26, 2024 21:42
@QxBytes QxBytes requested a review from a team as a code owner June 26, 2024 21:42
@QxBytes QxBytes force-pushed the alew/update-dir-permissions branch from 9bcb554 to 71af463 Compare June 26, 2024 22:37
@QxBytes QxBytes added this pull request to the merge queue Jun 27, 2024
@QxBytes QxBytes linked an issue Jun 27, 2024 that may be closed by this pull request
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2024
@QxBytes QxBytes added this pull request to the merge queue Jun 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2024
@QxBytes QxBytes added this pull request to the merge queue Jun 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2024
@rbtr rbtr added this pull request to the merge queue Jun 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 28, 2024
@QxBytes QxBytes added this pull request to the merge queue Jul 2, 2024
Merged via the queue into master with commit fb2ec7a Jul 2, 2024
93 of 94 checks passed
@QxBytes QxBytes deleted the alew/update-dir-permissions branch July 2, 2024 04:36
QxBytes added a commit that referenced this pull request Jul 2, 2024
update file lock directory permissions
QxBytes added a commit that referenced this pull request Jul 2, 2024
fix: update azure-vnet directory permissions (#2819)

update file lock directory permissions
QxBytes added a commit that referenced this pull request Jul 2, 2024
update file lock directory permissions
rbtr pushed a commit that referenced this pull request Jul 8, 2024
fix: update azure-vnet directory permissions (#2819)

update file lock directory permissions
@jpayne3506 jpayne3506 removed the needs-backport Change needs to be backported to previous release trains label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cni Related to CNI. fix Fixes something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race when creating azure-vnet lock directory with permissions
4 participants