Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: avm/res/web/hosting-environment - certain versions reaching end of life #3337

Closed
1 task done
matebarabas opened this issue Sep 20, 2024 · 4 comments · Fixed by #3500
Closed
1 task done
Assignees
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@matebarabas
Copy link
Contributor

matebarabas commented Sep 20, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/web/hosting-environment

(Optional) Module Version

No response

Description

Hi @tsc-buddy,

As it's been communicated here, some versions of the Azure resource used in your module have been retired. Please see more details here: https://techcommunity.microsoft.com/t5/apps-on-azure-blog/post-retirement-action-for-app-service-environment-v1-v2-logic/ba-p/4233407

Please make sure that

  1. your module is aligned with these changes (I think it already is, but please check and confirm)
  2. you have the following blurb added to the Notes section of your module's readme.md (Feel free to also include a pointer to the public announcement linked above.):
    "Certain versions of this Azure resource reached their end of life. The latest version of this module only includes supported versions of the resource. All unsupported versions have been removed from the related parameters."
  3. you have the following blurb added to the related parameter's description:
    "Certain versions of this Azure resource reached their end of life. The latest version of this module only includes supported versions of the resource. All unsupported versions have been removed from this parameter."

Thank you!

(Optional) Correlation Id

No response

@matebarabas matebarabas added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Sep 20, 2024
@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Sep 20, 2024
Copy link

@matebarabas, thanks for submitting this issue for the avm/res/web/hosting-environment module!

Important

A member of the @Azure/avm-res-web-hostingenvironment-module-owners-bicep or @Azure/avm-res-web-hostingenvironment-module-contributors-bicep team will review it soon!

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@tsc-buddy
Copy link
Contributor

I can confirm its only allowing v3, I shall updates the notes on readme as requested. Thanks @matebarabas

@tsc-buddy tsc-buddy removed the Needs: Triage 🔍 Maintainers need to triage still label Sep 20, 2024
@matebarabas
Copy link
Contributor Author

Thanks, @tsc-buddy! Please link the PR to this issue once you have it, so it self-closes. Thanks again!

@tsc-buddy tsc-buddy linked a pull request Oct 13, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants