Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

need option to disable rt_regionfix #101

Open
kennethsdavis opened this issue Oct 25, 2023 · 1 comment · May be fixed by #108
Open

need option to disable rt_regionfix #101

kennethsdavis opened this issue Oct 25, 2023 · 1 comment · May be fixed by #108

Comments

@kennethsdavis
Copy link

Using the API, it would be nice to prevent rt_prep_parallel from calling rt_regionfix. The default behavior of rt_regionfix is to look for a model.regexp file in the same folder as model.g and use it to re-number the regions defined in model.g. This feature allows users to modify developer-delivered models to affect application output.
@kennethsdavis
Copy link
Author

@brlcad
regionfix.c@74 looks to be a suitable candidate for the solution to this request. Currently rt_regionfix treats as an error the inability to open a given path to a REGEXP file. If this call to perror were replaced with a call to bu_log, then API users could effectively ignore the error condition.

kennethsdavis added a commit to kennethsdavis/brlcad that referenced this issue Dec 29, 2023
@kennethsdavis
consider the failure to open a regexp file a 'soft' error refs BRL-CA…
f4dfede 
…D#101
kennethsdavis added a commit to kennethsdavis/brlcad that referenced this issue Dec 29, 2023
@kennethsdavis
rework the region fix file message for readability refs BRL-CAD#101
254d029
@kennethsdavis kennethsdavis linked a pull request Dec 29, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rt_regionfix polite error reporting kennethsdavis/brlcad
1 participant
@kennethsdavis