Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of scratch module execution #206

Open
Shettland opened this issue Mar 1, 2024 · 0 comments
Open

Better handling of scratch module execution #206

Shettland opened this issue Mar 1, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@Shettland
Copy link
Member

With the new release 2.0.0 scratch.py executes the rsync command using SLURM's srun in order to provide better resource handling from the HTC cluster.

Although the module is perfectly functional using srun leads to a small problem: as the exit_code thrown by srun is automatically generated once the command is successfully executed, instead of once its finished, we are not correctly checking the exit status of the command. The workaround for this was to generate service_info.txt inside the original folder instead of the destination folder (inside /scratch/bi/). If by any reason rsync fails during its execution, although you will see this fail status in your terminal prompt, it will still report that the copy was successful.

It would be very helpful to find a solution for this, either waiting for the process to end (without using while + sleep) or some way to get the correct exit status.

@Shettland Shettland added bug Something isn't working enhancement New feature or request labels Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant