Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link shapes do not represent direction in point order of polyline #56

Open
lmz opened this issue Feb 28, 2022 · 2 comments
Open

Link shapes do not represent direction in point order of polyline #56

lmz opened this issue Feb 28, 2022 · 2 comments

Comments

@lmz
Copy link
Member

lmz commented Feb 28, 2022

The link shapes should represent the link direction by how the polylines are defined. This way, when one uses GIS to show an arrow head to represent direction or using a line offset to separate the drawing of bidirectional links, the direction is visible when the link is rendered. Currently, this is not the case.

In the attached image, the link layer has a symbology with both an arrowhead on the end, plus a link offset. Two links are selected (see right pane) and they are meant to be the reverse of each other (they have A1==B2 and B1==A2) but only one link is rendered implying the link geometry is the same rather than reversed.

(MTC asana task)

@lmz
Copy link
Member Author

lmz commented Feb 28, 2022

Screen Shot 2022-02-16 at 2 56 24 PM

@yuqiww
Copy link
Member

yuqiww commented Apr 11, 2022

It seems natural to create "opposite shapes" when creating reversed links for two-way OSM links.

lmz added a commit that referenced this issue Apr 21, 2022
- Use geofeather as intermediate format (since it's much faster)
- Add a lot of documentation inline
- Add reverse geometries for reverse links ( fixes #56 )
- Don't aggregate up to shared street links just yet -- punt to later step
- Performance improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants