Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProgressMeter removal in MDAnalysis 2.0 #19

Closed
IAlibay opened this issue Jun 21, 2020 · 2 comments
Closed

ProgressMeter removal in MDAnalysis 2.0 #19

IAlibay opened this issue Jun 21, 2020 · 2 comments

Comments

@IAlibay
Copy link
Collaborator

IAlibay commented Jun 21, 2020

As the progressmeter has now been replaced by the progressbar, the following will fail from 2.0 onwards:

propkatraj/propkatraj/propkatraj.py

Line 61 in 2abd91f

pm = mda.lib.log.ProgressMeter(universe.trajectory.n_frames,

I would be interested in attempting to refactor the code to use AnalysisBase instead if there is any interest in doing so.
@orbeckst
Copy link
Member

orbeckst commented Jul 4, 2020

YES, PLEASE! This might make for a decent example for code outside MDAnalysis.analysis can leverage AnalysisBase.

Also note that propka is now 3.2 so there might have been some API breaks. But the good news is that propka is now properly versioned and maintained.

This was referenced Jul 4, 2020
Open
Merged
@IAlibay
Copy link
Collaborator Author

IAlibay commented Jul 9, 2020

Closed with #26

@IAlibay IAlibay closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orbeckst @IAlibay