Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discuss solution to snapshot problem #15

Open
neptune-v opened this issue Jan 22, 2021 · 2 comments
Open

discuss solution to snapshot problem #15

neptune-v opened this issue Jan 22, 2021 · 2 comments

Comments

@neptune-v
Copy link
Contributor

neptune-v commented Jan 22, 2021

Possible alternatives:
1. Backtracing data from the chain
2. Implement views in the smart contract
3. Implement events and emit them in the correct function calls,

@kafeikui
Copy link
Contributor

My recommendation is adding event to popular external trxs. For demend like statistics for rank of deposit amount, it's hard to get information by some view in vault contract since vault token is tokenized as currency asset and extra storage space will be needed for tracing that. Instead with well-designed event, we can not only do statistics to support business operations, but make internal status in trxs observable, which is useful for tests.

@neptune-v
Copy link
Contributor Author

Agreed, let's do this. Thanks for the advice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants