Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently unusable on Mac due to the colors/theme, pref port action also a bit off #65

Open
jdeltoft opened this issue Apr 22, 2019 · 2 comments

Comments

@jdeltoft
Copy link
Contributor

jdeltoft commented Apr 22, 2019

image
This is what is looks like for me when running on Mac.

This is after I made a theme update per https://gist.github.com/gph03n1x/7281135

image

@jdeltoft
Copy link
Contributor Author

Also, when I start uPyloader when my preferred port isn't yet available, some other port is selected. But then this code was preventing my preferred port from having any action when I then turned on my nodemcu which was really the whole point of preferred port.

image

I updated it to use preferred port any time it's NEWLY found.

@BetaRavener
Copy link
Owner

I'll need to see about approving that dark theme PR - if it changes color scheme globally for everyone, not just those using dark theme, it would cause the same problems for other people.

I wouldn't change preferred port behavior either. I can leave it open for discussion but that setting is meant mostly as start-up setting, not port auto-detection. It's disturbing to workflow if port always changes to the preferred one if you are working on a device that is not on that port (say you normally use wifi but want to debug using UART for a while).

There's nothing wrong modifying uPyloader to your needs, I'm just not sure if that aligns with needs of majority of users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants