Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source icons still not included #19

Closed
zoccoler opened this issue Jun 24, 2024 · 3 comments
Closed

Source icons still not included #19

zoccoler opened this issue Jun 24, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@zoccoler
Copy link
Contributor

I tried installing 0.0.3 which should now contain the icons, but they did no show up in the plotter yet.

This should have been fixed via #17 , but it still does not work for me.

@zoccoler zoccoler added the bug Something isn't working label Jun 24, 2024
@haesleinhuepf
Copy link
Member

Hi Marcelo @zoccoler

I just saw this issue and know what pain it can be to make these things work. The folder specified in #17 :

include src/icons/*.png

does not exist. Try this folder instead:
src/biaplotter/icons

One can test this by executing this line on a local terminal. The output should then contain lines such as:

adding 'biaplotter/icons/button1.png'

Best,
Robert

@zoccoler
Copy link
Contributor Author

Hi @haesleinhuepf ,

Thank you, this was fixed yesterday by @stefanhahmann in #20 :)
I released a new version after that (0.0.4), it should be working now, if not please let me know, otherwise, please feel free to close this issue.

Best,
Marcelo

@zoccoler
Copy link
Contributor Author

zoccoler commented Jul 4, 2024

I am closing this, please re-open in case the problem persists.

@zoccoler zoccoler closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants