Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise UI mock-ups for setting up human readable addresses #1083

Open
GBKS opened this issue Mar 19, 2024 · 4 comments
Open

Revise UI mock-ups for setting up human readable addresses #1083

GBKS opened this issue Mar 19, 2024 · 4 comments
Assignees
Labels
Copy Task is about improving text. Design Task is about designing something. How it works Referring to the How it works section.

Comments

@GBKS
Copy link
Contributor

GBKS commented Mar 19, 2024

This is a follow-up PR for #1082. The new page has conceptual mock-ups for setting up addresses, but we can go in much more detail, which will be more helpful for builders. There was also feedback on this topic here.

This is a placeholder issue for now, as I don't have all the questions and tasks 100% clear in my head yet. Will come back to this one, along with any other feedback that comes in.

@GBKS GBKS added Copy Task is about improving text. Design Task is about designing something. How it works Referring to the How it works section. labels Mar 19, 2024
@GBKS GBKS self-assigned this Mar 19, 2024
@GBKS
Copy link
Contributor Author

GBKS commented Apr 29, 2024

There was more feedback on the screens here.

Also need to revisit the point about informing users when payment info changes, to be only at the moment of initiating a payment, per Stephen's comment.

@BitcoinErrorLog
Copy link

BitcoinErrorLog commented Jun 20, 2024

I remain totally opposed to including non-standard, not-used, speculative proposals inside of something that is meant to be a general guide. It is inaccurate for the context, misleading, and potential king-making behavior. (referring to the "BOLT12" bitcoin address proposal from Matt, which is by no means accepted by anyone, anywhere. Nor is there anything even close to a consensus that this should be done.)

@GBKS
Copy link
Contributor Author

GBKS commented Jun 20, 2024

@BitcoinErrorLog I assume your comment was meant for the main PR #1082, right?

It's interesting you use the term king-making behavior. I personally don't see the guide as that influential, but I also can't prove otherwise. The way I think about it is that we should be OK with discussing less widely adopted ideas in the guide. It can help validate if those ideas are good and identify the right way to go about implementing them. But that should also come with appropriate disclaimers, and sometimes a strong statement not to do something. It's obviously a fine line.

Either way, I don't want to hark on something where there is strong pushback. What do you think is a good way forward then? Leave this work as a PR until more consensus has formed? What would be consensus to you? A certain number of serious wallets projects having implemented it?

@BitcoinErrorLog
Copy link

I suppose I am commenting on overall Guide policy. I assume a goal is being a resource for onboarding designers & related roles into conventional, and even modern, knowledge and examples that may be relevant to their work.

I agree that neither of us could effectively measure the effectiveness of any king-making behavior, I just mentioned it as something best avoided altogether. And it is certainly avoidable if we agree on the goals.

You could do as you mention and require a certain standard of adoption, or other approaches, or even clarifying the goals to include being a resource for any known Bitcoin proposals, or Spiral proposals, or regardless of relevance, as long as they are Bitcoiny, like Runes, etc.

In the end, my opinion is simply that I imagine the target user of the guide will expect a certain amount of standardness and practicality to the advice contained within it, and I don't know a good argument for including speculative, unsupported proposals like this one.

I certainly defer to you and the people putting the actual work into this! Just trying to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Copy Task is about improving text. Design Task is about designing something. How it works Referring to the How it works section.
Projects
None yet
Development

No branches or pull requests

2 participants