Batching with array #108
Open
Batching with array #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shesek
reviewed
Oct 15, 2024
src/electrum/server.rs
Outdated
| &mut self, | ||
| cmd: Value, | ||
| empty_params: &Value, | ||
| start_time: Instant, |
There was a problem hiding this comment.
Shouldn't the start_time start ticking separately for each handle_value call?
There was a problem hiding this comment.
yes, it makes sense. Done in b8f4524
|
Should we limit the number of requests per batch? |
shesek
reviewed
Oct 18, 2024
| @@ -137,3 +140,44 @@ fn test_electrum() -> Result<()> { | |||
|
|
|||
| Ok(()) | |||
| } | |||
|
|
|||
| /// Test the Electrum RPC server using an headless Electrum wallet | |||
There was a problem hiding this comment.
The comment here should be updated, "using a raw TCP socket" or something similar
Do we have limits for "new-line separated" batch requests? Is it different here? How much do you propose as the limit here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently electrs support batching by separating requests via new lines, however, other impls support it also via json array as explained in the cited issue. This add support for batching requests via json array
close Blockstream/esplora#516