-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE]Use WebSocket #244
Comments
If this is to be implemented, please keep the HTTP fetch option as a persistent choice. (i.e. don't deprecate/remove it). When deploying BlueMap at scale (for example, as an interactive component displaying a static world on a website) HTTP fetches are much better, as tools exist to optimize the delivery of static content over HTTP. These same tools do not exist for WebSockets |
Do note that if websockets are going to be used, we'd also need to implement |
There is currently no intend to use web-sockets for the map-tiles .. in my opinion, http-requests are perfectly fine for that :) |
Maybe instead of web socket, just use server side event ? |
I will consider it, yes :) |
With HTTP/3 becoming more common by the day, I'd say websockets wouldn't add much anymore. Pros
Cons
I do not know how the internal webserver works from a code-perspective but I think the changes should be relatively minimal while still having a bigger impact than using websockets would have. |
HTTP/3 is unlikely to be ever supported by BlueMap as it has been previously established that BlueMap won't support TLS by itself. To use HTTP/3 one should host the website with an external webserver such as nginx. |
I would say using websockets for external live updates would be amazing. Maybe if hosted by the server it still does HTTP requests, but if you move external you have the option of using websockets instead of ajax requests for player positions. |
I suggest bluemap use WebSocket to get data, that will reduce many unnecessary web request. Of course, bluemap need keep http API to compatible with the old client
The text was updated successfully, but these errors were encountered: