Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI #71

Open
1 of 2 tasks
s0lst1ce opened this issue Oct 26, 2019 · 2 comments
Open
1 of 2 tasks

CI #71

s0lst1ce opened this issue Oct 26, 2019 · 2 comments
Assignees
@s0lst1ce
Labels
enhancement New feature or request github repositery changes quality all issues which only affect the way code is written and that won't affect functionnality
Milestone
Long term develop...

Comments

@s0lst1ce
Copy link
Collaborator

s0lst1ce commented Oct 26, 2019 •
edited
Loading

My feature request is about

  • A new feature

Description of the solution I'd like
Adding CI to the repo would help to enforce coding styles and make sure less errors are committed.

Additional context
We may use actions from one of my other repos.

What needs to be done

  • Add CI
  • Correct code accordingly
@s0lst1ce s0lst1ce added enhancement New feature or request quality all issues which only affect the way code is written and that won't affect functionnality github repositery changes labels Oct 26, 2019
@s0lst1ce s0lst1ce self-assigned this Oct 26, 2019
s0lst1ce added a commit that referenced this issue Oct 26, 2019
@s0lst1ce
added basic CI, see #71
9a85abb
@s0lst1ce s0lst1ce mentioned this issue Oct 27, 2019
Closed
4 tasks
@s0lst1ce s0lst1ce mentioned this issue Nov 13, 2019
Closed
2 tasks
@s0lst1ce
Copy link
Collaborator Author

This would need some heavy improvement. It may be a good idea to merge some CD with it and have a test apply black to it.

@s0lst1ce s0lst1ce added this to the Long term development milestone Mar 13, 2020
@s0lst1ce
Copy link
Collaborator Author

s0lst1ce commented May 8, 2020

Write tests for some class and methods in utilities. The for which I think this would be beneficial are:

  • ConfigFile
  • Translator
  • ConfigEntry
  • to_datetime
  • assert_struct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s0lst1ce s0lst1ce

Labels
enhancement New feature or request github repositery changes quality all issues which only affect the way code is written and that won't affect functionnality
Projects
None yet
Milestone
Long term development
Development

No branches or pull requests
1 participant
@s0lst1ce