-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numbat: Install based app #2589
Comments
Would you be willing to follow our app creation guidelines so that the app icon, installation scripts, description, and website url are given appropriate values? https://pi-apps.io/wiki/development/Creating-an-app/ |
Also, I'm assuming you are a Pi-Apps user. Do you think it would fit better under Tools, Engineering, Office, or somewhere else? We currently do not have a dedicated Mathematics category. |
The Engineering category. |
The deb file automatically installs an icon and a .desktop file. Icon link: https://github.com/sharkdp/numbat/blob/master/assets/numbat.svg |
Have you used Pi-Apps? Can't quite tell if you are refusing to read our docs or if you plan to work on this later. |
Sorry, I didn't realize I have to create the zip file using Pi-Apps. I will get back soon. |
You don't have to, but we do request that you follow the app folder format so we don't have to do it for you. |
A zipfile was found in the body of your issue. Click to show contents preview
#!/bin/bash
version=1.11.0
install_packages https://github.com/sharkdp/numbat/releases/download/v${version}/numbat_${version}_armhf.deb || exit 1
#!/bin/bash
#Allow packages required by this app to be uninstalled
purge_packages || exit 1
#!/bin/bash
version=1.11.0
install_packages https://github.com/sharkdp/numbat/releases/download/v${version}/numbat_${version}_arm64.deb || exit 1
|
I have updated the zip file. I am reopening the issue |
Passes installation CI on all supported systems https://github.com/Botspot/pi-apps/actions/runs/9131925909 I checked the debs and they have no dependencies in the control file. That should be corrected upstream before this can be included as these do depend on GLIBC (minimum version differs depending on the architecture). Please open a bug report of that upstream @archisman-panigrahi and link back here. They can use the standard debian packaging tool |
AFAIK glibc is the only dependency, and AFAIK, all recent versions of glibc work. Is it really necessary to have it in the .deb package as an explicit dependency for inclusion in pi-apps, given all the supported distros (Raspberry Pi OS/Ubuntu) have glibc preinstalled and that is not going to change anytime soon? |
Having the proper dependencies listed allows our CI and users to verify that the binary will work on their system. If something changes on the build end future builds could result in a much higher glibc requirement (eg: 2.38) and there would be no way for our CI to catch such issues and prevent upgrades. It's best practice for 3rd party packages and a requirement for real debian/Ubuntu packages. |
Here is the upstream issue sharkdp/numbat#434 (comment) |
What is the name of the app?
numbat
Where is the app hosted?
New versions are hosted in https://github.com/sharkdp/numbat
About the app
Numbat is a an excellent scientific calculator that supports physical units.
Upload file or Add PR Link
Numbat.zip
https://github.com/sharkdp/numbat/releases/tag/v1.11.0
Confirmations
The text was updated successfully, but these errors were encountered: