Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect and response timeout support #31

Open
WyriHaximus opened this issue Dec 30, 2018 · 3 comments
Open

Connect and response timeout support #31

WyriHaximus opened this issue Dec 30, 2018 · 3 comments

Comments

@WyriHaximus
Copy link
Collaborator

Having both those time outs supported would be great. Running into an issue where it continues to wait for a requests that for some reason never completes
@Brunty
Copy link
Owner

Brunty commented Dec 30, 2018

Curl has CURLOPT_CONNECTTIMEOUT and CURLOPT_TIMEOUT so this should be fine to add. Just need to work out a test for it.

If we set defaults then allow them to be overridden with options, perhaps connect-timeout and timeout (need to work out short options too)

Thoughts @WyriHaximus? I'll add you as a collaborator too as you've been so helpful with this tool in the past :)

@WyriHaximus
Copy link
Collaborator Author

Sure I'm game 👍 .

@WyriHaximus
Copy link
Collaborator Author

@Brunty should the CLI option override the value configured in .cigar.json or the other way around?

WyriHaximus added a commit to WyriHaximus-labs/cigar that referenced this issue Dec 31, 2018
@WyriHaximus
Adding timeout options both CLI and .cigar.json
e44ac97 
🎆🎆🎆 Happy New Year 🎆🎆🎆

This PR adds the timeout options discussed in Brunty#31
Closes / implements Brunty#31

Any values in the CLI are overridden by what ever value is in the `.cigar.json`
@WyriHaximus WyriHaximus mentioned this issue Dec 31, 2018
Merged
Brunty pushed a commit that referenced this issue Mar 12, 2019
@WyriHaximus @Brunty
Adding timeout options both CLI and .cigar.json (#32)
6389b9e 
* Adding timeout options both CLI and .cigar.json

🎆🎆🎆 Happy New Year 🎆🎆🎆

This PR adds the timeout options discussed in #31
Closes / implements #31

Any values in the CLI are overridden by what ever value is in the `.cigar.json`

* Removed short hand (ct) for --connect-timeout via #32 (comment) by @Brunty

* Test response timeout .json config and CLI flags through stubs via #32 (comment) by @Brunty

* s is now short the connect-timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WyriHaximus @Brunty