massive water craters in weird places

[j4ix]

Describe the bug
there are massive holes in the ground with stone rims that have water sitting deep at the bottom

To Reproduce
Describe the steps it takes to reproduce the bug
Example:

1. Join the game
2. Execute command /tpll 38.678039072306305, -77.25716596226385
3. compare to a map and terra121 original branch

Expected behavior
i expect it to behave like terra121 and not put massive random holes in the ground
(ye i did just test both mods with freshly generating worlds)

Screenshots

look around this isn't the only one in this area
and i'm saying this doesn't happen in terra121 but does in terra++

Error Logs
n/a

Terra121 or Terra++ (please complete the following information):

• i talked about it

Version (please complete the following information):

• im using my own custom bundle of mods all having to do with terra121 and building only but that's nnot the problem here

[j4ix]

another example that is far less severe than the craters that are next to each other, but still equally as strange in my opinion
/tpll 38.68454315076617, -77.26091994159331

notice on an actual map that this seriously doesn't happen
there is no pushed in terrain like this and terra121 generates it correctly

i would love to use this great generator but it's making earth harder to build on than terra121 atm...

[SmylerMC]

1:
You are running an unreleased, untested and unsupported version of Terramap, please don't report bugs to other projects like this when using it.
It is very unlikely to be the cause of the bug here, so I will just ignore it, but really, please don't, you could be waisting people's time with irrelevant issues.

2:
Which version of terra++ are you running?
It is still a work in progress with regular updates and changes, especially surrounding water handling right now. We can't help if we don't know exactly what which version you have.

3:
As I said, it's a work in progress, so for the moment you still need to be ready to deal with bugs when using it (not that we want you to, but you should always plan for the worst).

[j4ix]

i had absolutely no idea terramap could affect generation. this is obviously news to me. i’m about to try without it, even though terramap now requires this project as a dependency...

i just used the latest release terra++ as of yesterday from jenkins and every other mod was built from source (terraplusplus-0.1.405-1.12.2.jar) (build #36 doWater always enabled) (this has been the latest release for three days)

[j4ix]

i removed your mapping application @SmylerMC just to generate the world and this is still definitely a valid, useful bug.

[RudeYeti]

This seems to be a problem with the OSM Data, but it probably will be fixed in the next TerraPlusPlus update. The branch Fast-OSM is currently being worked on by DaPorkchop, and it's close to being finished. That will include better data to generate the world with.

[SmylerMC]

i had absolutely no idea terramap could affect generation

It cannot, to clarify a bit: I consider TM to be still in beta and I often let Master in a terrible state, please just don't report issues to other projects when using an "unofficial" build.

[SmylerMC]

This issue also affects the fast-osm branch. Looks like it comes from in the Mapzen dataset. ( Here is one corresponding tile ).
It's probably related with this special check in terra121.

[DaMatrix]

unable to reproduce using the latest terra++, cc and cwg from jenkins (no other mods):

what projection are you using? have you changed the configuration for overpass or elevation datasets at all?

[j4ix]

i used planet earth -> bte upright model and bte from the world type selection now and no changes to other configs

[j4ix]

uhh i'm also not using minecraft bundled java because of the cert problem i have no idea if that's an issue
i'm using latest java 8 or i don't get trees
i'm aware of letsencryptcraft, i don't have it

[j4ix]

i've deleted the config and all other mods, so the config is fresh, and created a brand new world with the bte model and i have the same results as earlier. given i'm using latest java 8

[j4ix]

using bundled java yields exact same results for me. deleted cache too. brand new world everytime.

[SmylerMC]

Got this with the latest commit on fast-osm:

[j4ix]

@DaMatrix could i get ur terrapp config

[DaMatrix]

i used all the default settings, and the bte preset.

[j4ix]

are you absolutely positive you aren’t using a custom elevation server that’s newer than master
i heard you were working on em

[SmylerMC]

@DaMatrix look at the tile I linked above

[DaMatrix]

i saw that, but that still doesn't explain why it works perfectly fine for me at that same location :thonk:

[j4ix]

ok, but i did fresh minecraft and java install and my computer’s pretty cool (used terrapp dowater build + old cwg & cc hashes matched build versions, fresh world every test)

[Agrrox]

I can replicate the issue with t++ 579.

mods:

[___MixinCompat-0.8___].jar
[1.12.2]+VersionChecker-1.4.0.jar
bte_tr-1.01.4.jar
bteutilities-2.0.jar
ccpregen-0.0.21.jar
ChunkAnimator-MC1.12-1.2.jar
Controlling-3.0.10.jar
CubicChunks-1.12.2-0.0.1184.0-SNAPSHOT-all.jar
CubicWorldGen-1.12.2-0.0.140.0-SNAPSHOT-all.jar
effortlessbuilding-1.12.2-2.16.jar
foamfix-0.10.11-1.12.2.jar
Hwyla-1.8.26-B41_1.12.2.jar
jei_1.12.2-4.16.1.301.jar
journeymap-1.12.2-5.7.1.jar
mcosm-0.4.0.jar
OptiFine_1.12.2_HD_U_G5.jar
performant-1.12.2-1.10.jar
replaymod-1.12.2-2.5.1.jar
rhino-1.7.12.jar
terramap-1.0.0-beta7.8_1.12.2.jar
terraplusplus-1.1.0.579-1.12.2.jar
VanillaFix-1.0.10-150.jar
Wawla-1.12.2-2.6.275.jar
WorldEdit-CUI-FE3-1.12.2-3.0.9.jar
worldedit-forge-mc1.12.2-6.1.11-cc1184-SNAPSHOT-dist.jar