Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose method and client-level specification of desired units for input/output #150

Open
bdpedigo opened this issue Feb 16, 2024 · 1 comment

Comments

@bdpedigo
Copy link
Collaborator

we discussed two interfaces for specifying the units for dimensions for inputs and outputs:

  1. methods could implement a units/resolution/etc. flag which denotes what units a user is inputting (e.g. for a bounding box) or expecting (e.g. for a spatial location return value). the default would be None which would not change the current behavior
  2. the CAVEClient class could also implement the same flag, and would also be None by default. specifying this would lead to all subsequent calls being in those units, unless overridden at the method level
@bdpedigo
Copy link
Collaborator Author

Functions/methods with some kind of spatial input/return:

  • most things in annotation, e.g.
    • annotation.create_table: voxel_resolution
      • already has a flag for this kind of thing
    • annotation.post_annotation_df: position_columns ?
    • annotation.update_annotation_df
  • chunkedgraph
    • do_merge
    • execute_split
    • find_path
    • get_contact_sites
    • get_operation_details
    • get_subgraph
    • preview_split
  • l2cache
    • get_data
      • at least for the nm properties... not sure what to do here
  • materialization
    • basically anything with query in the name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant