-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize code formatting? #169
Comments
Happy with moving to ruff, but would prefer to enforce with a GitHub action if possible rather than tests. |
yeah i meant a github action that would check with ruff |
I mean I'd rather it just do the formatting than test agains it. If it would fail tests otherwise, why not just let the tool fix it. |
Closed by #170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Spinning off conversation from #167
I propose using ruff as an autoformatter and enforcing this in the tests.
Upside is fewer formatting-based diffs on PRs and cleaner looking code IMO.
Downside is an annoyance when tests fail just because you didn't run autoformatting. I think this can be alleviated by using pre commit hooks or just setting up code editor to run it automatically on save.
cc: @ceesem
The text was updated successfully, but these errors were encountered: