Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover text over the “Ontology Search” button to briefly explain what it does #503

Closed
kcs3 opened this issue Nov 16, 2021 · 10 comments

Comments

@kcs3
Copy link
Collaborator

kcs3 commented Nov 16, 2021

Compose new text...

@kcs3
Copy link
Collaborator Author

kcs3 commented Nov 16, 2021

Suggested hover text for the Ontology search button: "For each exactly matched search term, Ontology search traverses the hierarchical ontology structure to return any child node that has observations"

@kcs3
Copy link
Collaborator Author

kcs3 commented Dec 17, 2021

Examples where "Ontology Search" provides additional results, as mentioned in #487 (from Zhou):
• for disease context: search "organ", three results. "ontology search", 7 more results
• for ECO: test case: search ECO_0000059 and you will get one result. If you do "ontology search", you will get three more results, which are children of ECO_0000059.
• for observation: ECO_0000059 TP53. there is no direct 'intersection' but there will be intersection between child of ECO_0000059 (i.e. ECO_0000016) and TP53 so at least one observation result

One or more of these could be included in the hover text

@kcs3
Copy link
Collaborator Author

kcs3 commented Dec 17, 2021

Add this modified version of Aris' suggestion as hover text to the Ontology Search button:
"Expand result set to include subjects that are ontology children of original hits".

Another suggestion, to include the text "Incremental results retrieved through the ontology search are decorated with a "ONTO" icon" is made redundant because we provide a message to that effect above the results in #507.

Add this text to the hover text for the basic search feature:
"Use of quotes to surround multi-word search terms is advised to avoid a large number of hits".

@kcs3 kcs3 removed their assignment Dec 17, 2021
@zhouji2013 zhouji2013 added this to the Ongoing improvements milestone Dec 22, 2021
zhouji2013 added a commit that referenced this issue Dec 22, 2021
@kcs3
Copy link
Collaborator Author

kcs3 commented Jan 7, 2022

Testing on test server.

For the final item:

'Add this text to the hover text for the basic search feature:
"Use of quotes to surround multi-word search terms is advised to avoid a large number of hits".'

the hover text was added to the actual search button rather than to the instructions hover-text over the search box. Maybe it is good this way...

The hover text for the "onto" button is correct,.

@arisf
Copy link

arisf commented Jan 7, 2022

I agree with Ken, the hover text should not be on the Search button. Instead, it should be added to the existing hover text, as follows:

Please enter the keyword(s) you would like to search on the website. Use of quotes to surround multi-word search terms is advised, to avoid a large number of hits. You may enter multiple search terms, but do not use "AND" or "OR".

@kcs3
Copy link
Collaborator Author

kcs3 commented Jan 8, 2022

Above change tested on columbia test server, verified correct.

@arisf
Copy link

arisf commented Jan 10, 2022

I see the following behavior (both in Chrome and Edge):

  • Submit a search (any will do).
  • In the results page, hover over the "Ontology Search" button. This will show the info text. Hover away from the button. This will hide the info text. Up to here, all is fine.
  • Now click on the "Ontology Search" button, to initiate an ontology search. This causes the info text to appear again and then remain permanently visible, regardless of hovering or not on the button. Furthermore, it remains visible after navigating to any other Dashboard page.

@zhouji2013
Copy link
Collaborator

I reproduced this problem. It is an interesting issue. It seems that when Chrome and Edge disabled the button, it becomes totally disabled including the ability to turn off the hover text, but Firefox keeps it able to turn off the hover text.

@arisf
Copy link

arisf commented Feb 11, 2022

Confirmed on testing instance.

@arisf
Copy link

arisf commented Jun 2, 2022

tested on production server.

@arisf arisf closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants