Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ontology searches do not return the expected results #512

Closed
arisf opened this issue Mar 2, 2022 · 3 comments
Closed

Some ontology searches do not return the expected results #512

arisf opened this issue Mar 2, 2022 · 3 comments

Comments

@arisf
Copy link

arisf commented Mar 2, 2022

Notice that "diffuse glioma" is a parent of "glioblastoma" in the NCI Thesaurus. When execuring a search for the term "diffuse glioma" (quotes included) we get zero results back. So far so good, presumably there are no observations matching the term. But then, when clicking on the "Ontology Search" button, nothing is returned either, despite the fact that the child subject "gliobastoma" is associated with many observations. Per the specification of the ontology search functionality (issue #487), the "glioblastoma" subject should have been returned.

@arisf arisf added the bug label Mar 2, 2022
@zhouji2013 zhouji2013 added this to the Ongoing improvements milestone Mar 3, 2022
@zhouji2013
Copy link
Collaborator

This is because "diffuse glioma" C129325 is not in the background data. The source of the background data is NCI_thesaurus_terms.txt. We need Vlado's help to verify when and how this file is updated.

zhouji2013 added a commit that referenced this issue Apr 23, 2022
@arisf
Copy link
Author

arisf commented Apr 25, 2022

Confirmed fixed on development server.

@arisf
Copy link
Author

arisf commented Jun 2, 2022

Verified on production server.

@arisf arisf closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants