From cee5d4421a1b179b81b22d48ae9fd3da04480fb2 Mon Sep 17 00:00:00 2001
From: sfisher <scott.fisher@ucop.edu>
Date: Wed, 13 Nov 2024 15:35:01 -0800
Subject: [PATCH] The "help" icon and tag was broken which produced bad tags
 and text since the attributes were not quoted correctly. See the Alt-text and
 title text for accessibility for the help button.

---
 ui_tags/templatetags/layout_extras.py | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/ui_tags/templatetags/layout_extras.py b/ui_tags/templatetags/layout_extras.py
index c409b524..af4a0948 100644
--- a/ui_tags/templatetags/layout_extras.py
+++ b/ui_tags/templatetags/layout_extras.py
@@ -125,19 +125,15 @@ def help_icon(
         "Click for additional help" + " " + str(specifics)
     )
     return django.utils.html.format_html(
-        '<a href="#" title="ID type information" class="button__icon-link" id={} role="button" data-toggle="popover" data-placement={} data-trigger="click" tabindex="0">'
-        '<img src="/static/images/iconHelp.svg" alt={}  class={} title={}/>'
+        '<a href="#" title="ID type information" class="button__icon-link" id="{}" role="button" data-toggle="popover" '
+        'data-placement="{}" data-trigger="click" tabindex="0">'
+        '<img src="/static/images/iconHelp.svg" alt="{}"  class="{}" title="{}" />'
         '</a>',
         id_of_help,
         placement,
         title,
         css_class,
         title
-        # '<a href="#" class="button__icon-link" id="' + str(id_of_help) + '" ' +
-        # 'role="button" data-toggle="popover" data-placement="' + placement + '" ' +
-        # 'data-trigger="click" tabindex="0">' +
-        # '<img src="/static/images/iconHelp.svg" alt="' + str(title) + '"' +
-        # ' class="' + str(css_class) + '" title="' + str(title) + '"/></a>'
     )