Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply security updates to EZID UI packages #519

Closed
jsjiang opened this issue Nov 29, 2023 · 10 comments · Fixed by #520
Closed

Apply security updates to EZID UI packages #519

jsjiang opened this issue Nov 29, 2023 · 10 comments · Fixed by #520
Assignees

Comments

@jsjiang
Copy link
Contributor

jsjiang commented Nov 29, 2023

Apply security updates to the EZID UI packages

@jsjiang
Copy link
Contributor Author

jsjiang commented Nov 29, 2023

Routine dependency scans ticket: #494

@jsjiang
Copy link
Contributor Author

jsjiang commented Dec 4, 2023

Joel provided fixes and documented changes in Pull request for Update EZID UI build tool packages to fix critical vulnerabilities

@jsjiang
Copy link
Contributor Author

jsjiang commented Dec 4, 2023

Deployed branch ui-toolkit-updates on ezid-dev for testing.

@jsjiang
Copy link
Contributor Author

jsjiang commented Dec 5, 2023

Functional test by running verify_ezid_after_patching.py: passed
UI tests: Maria and Jing performed UI tests. All look good.

@jsjiang
Copy link
Contributor Author

jsjiang commented Dec 6, 2023

  • Rushiraji performed UI test on ezid-dev
  • Merged pull request
  • created release tag v3.2.1 and release note
  • deployed v3.2.1 on ezid-stg

@jsjiang
Copy link
Contributor Author

jsjiang commented Dec 6, 2023

@JoelCDL Hi Joel, I merged the pull request and the fixes cleared almost all Dependatbot alerts. Great job! Thank you!

There are still two more high security alerts (https://github.com/CDLUC3/ezid/security/dependabot):

  • from the UI packages: "Prototype Pollution in lodash.merge"
  • from EZID app: ReDos

I will work on the EZID one. Can you take a look at the UI one and let me know if we need to do anything to clear it.

Thank you

Jing

@JoelCDL
Copy link
Contributor

JoelCDL commented Dec 6, 2023

@jsjiang With the lodash.merge issue, you can click the "Create Dependabot security update" here, then merge in the change: https://github.com/CDLUC3/ezid/security/dependabot/8

@jsjiang
Copy link
Contributor Author

jsjiang commented Dec 6, 2023

@JoelCDL Got it. Thank you Joel! -Jing

@jsjiang
Copy link
Contributor Author

jsjiang commented Dec 7, 2023

Failed to update lodash.merge due to conflicting dependencies:

Dependabot cannot update lodash.merge to a non-vulnerable version
The latest possible version that can be installed is 3.3.2 because of the following conflicting dependencies:

[email protected] requires lodash.merge@^3.1.0
[email protected] requires lodash.merge@^3.3.2 via [email protected]
No patched version available for lodash.merge
The earliest fixed version is 4.6.2.

@jsjiang
Copy link
Contributor Author

jsjiang commented Dec 7, 2023

Deployed on ezid-prd 12/6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants