Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ask-and-tell interface depends on the order of solutions #6

Open
nikohansen opened this issue Aug 19, 2022 · 0 comments
Open

ask-and-tell interface depends on the order of solutions #6

nikohansen opened this issue Aug 19, 2022 · 0 comments

Comments

@nikohansen
Copy link
Contributor

nikohansen commented Aug 19, 2022

It seems that the Sofomore.tell method depends on the order of solutions delivered by ask and stored in Sofomore._told_indices. This breaks the original contract of how ask-and-tell is supposed to work: the reason why the first argument of tell is a list of solutions is that we don't assume that these solution must be the same solutions which ask delivered previously.

The problem in our context is that we need to attribute solutions to the kernels they originate from. One way to go about this problem differently could be a dictionary that stores the kernel of each solution in ask, for example using the
SolutionDict class, and this dictionary then can be used in tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant