Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A typo in model.py? #12

Open
XZ-X opened this issue Feb 22, 2023 · 0 comments
Open

A typo in model.py? #12

XZ-X opened this issue Feb 22, 2023 · 0 comments

Comments

@XZ-X
Copy link

XZ-X commented Feb 22, 2023

Hi,

Recently I'm following up DIRTY. The work is great, and the code repo is impressive. Thank the developers for the efforts!

Just want to mention that there might be a typo in the following file: (dirty/model/model.py:496), the variable in task_targets should be targets, instead of preds.

DIRTY/dirty/model/model.py

Line 496 in 7a5514a

f"{task}_targets": preds,

@XZ-X XZ-X changed the title A typo in dumpping model results? A typo in model.py? Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@XZ-X