You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This ticket collects things to improve on error reporting, when the tools get incorrect input.
If no Interface is in the YAML, then no output. The D-Bus generator doesn't fail until the XML-reformatting where it says there is no start node (with an ugly exception backtrace).
Instead, check that an Interface node exists and/or check if generation result is empty, and report it to the user.
Related to the above, the current template-driven generators like BAMM, DTDL, and protobuf need to be updated for Interface. They don't fail because they just loop over "all methods in the Namespace", etc. So if there aren't any, the output will be mostly empty. Anyhow, perhaps this could be considered correct behavior for a file without an Interface node, but they should be updated.
Ultimately, add a check for Interface node, in the generic ifexgen - at least it probably should output a warning.
The text was updated successfully, but these errors were encountered:
gunnarx
added
the
discussion
Things that need some thinking, and feedback from several to find consensus first.
label
Aug 21, 2023
When the implementation switched to dacite, it does quite good checking for incorrect IFEX files but the error messages are not always the best. It can create an exception and ugly-backtrace if the input is not right. So the third item to improve is friendly messages with clear reference to the line number (which is lost currently in the YAML -> dictionary -> dataclass conversion.
This ticket collects things to improve on error reporting, when the tools get incorrect input.
If no Interface is in the YAML, then no output. The D-Bus generator doesn't fail until the XML-reformatting where it says there is no start node (with an ugly exception backtrace).
Instead, check that an Interface node exists and/or check if generation result is empty, and report it to the user.
Related to the above, the current template-driven generators like BAMM, DTDL, and protobuf need to be updated for Interface. They don't fail because they just loop over "all methods in the Namespace", etc. So if there aren't any, the output will be mostly empty. Anyhow, perhaps this could be considered correct behavior for a file without an Interface node, but they should be updated.
Ultimately, add a check for Interface node, in the generic
ifexgen
- at least it probably should output a warning.The text was updated successfully, but these errors were encountered: