Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using 'validate' attritbute when using VSS with VISS for access-control #349

Open
renjithrajagopal-sudo opened this issue May 2, 2024 · 3 comments

Comments

@renjithrajagopal-sudo
Copy link

Hey, I'm just wondering if 'validate' attribute is part of standard VSS catalogue or not. As it is only applicable to use along with VISS for access-control & token validation, what would be best way to generate the VISS binary without hitting 'strict' compiler termination that was introduced recently. Patching Makefile to bypass 'strict' is short term solution for sure.

@erikbosch
Copy link
Collaborator

It is true that validate is not a VSS standard atttribute. The VSS Makefile is mostly intended for testing of the VSS standard catalog. If you modify VSS in your own fork then you could as you say modify Makefile to use the arguments you need. But if you are only interested in the binary tool, you could as well run the relevant code (vspec2binary.py) manually from you build-environment. That makes it easier

binary:
	cd ${TOOLSDIR}/binary && $(MAKE)
	${TOOLSDIR}/vspec2binary.py -u ./spec/units.yaml ./spec/VehicleSignalSpecification.vspec vss_rel_$$(
cat VERSION).binary

The tooling is as of today not adapted to have tool-specfic attributes like validate
A possible improvement could be that tools like vspec2binary.py could add tool-specific attributes that would be considered
OK if running in strict mode for that particular tool

FYI: @UlfBj

@UlfBj
Copy link
Contributor

UlfBj commented May 2, 2024

I think it should be possible to call the Makefile with an "no-strict" argument to avoid strict to be applied.
Strict would be default, but it would offer the possibility for those who want so to not apply it, without having to do a lot of manual work.

@renjithrajagopal-sudo
Copy link
Author

Fork & patched solution is bit costly considering with the maintenance overhead down the line. Having no-strict also could introduce 'invalid attribute or unknown styling' to binary targeted for VISS which is not an optimal solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants