Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize CrySL Architecture #200

Open
1 of 3 tasks
AnakinRaW opened this issue Nov 8, 2019 · 1 comment
Open
1 of 3 tasks

Reorganize CrySL Architecture #200

AnakinRaW opened this issue Nov 8, 2019 · 1 comment
Assignees

Comments

@AnakinRaW
Copy link
Collaborator

AnakinRaW commented Nov 8, 2019

As discussed in today's meeting:

  • Perform a relabeling fro CrypSL to CrySL java source files
  • Extract and move (where possible) CrySL specific code to CrySL Repo (e.g.: such as CrySLRulesetSelector, etc.)
  • Move relevant constants/enums (like the CrySL source file ending) into a separate file

In edit for my suggestion about to referencing CrySL in this Repo: I didn't look carefully enough what exactly was referenced. I was under the assumption that this repo depends on the Ruleset Repo. As this obviously is not the case my comment becomes obsolete. Depending on the CrySL Engine of course makes sense. I'd still agree however to minimize the referenced code basis by splitting the CrySL-Repo into more independent projects

@smeyer198
Copy link
Contributor

smeyer198 commented Jul 15, 2024

Since this issue may become relevant in the future, the CrySL specific code concerns all classes in the packages crypto.rules and crypto.cryslhandler. In total, reading the rules is not part of the actual analysis. Instead, the analysis takes a Collection of CrySLRule as input and runs the analysis with them. One can obtain a collection using the RulesetReader. Therefore, the following new tasks arise:

  • Move the crypto.rules and crypto.cryslhandler into the CrySL Repository (probably into a new submodule)
  • Move the tests for reading the rules into the CrySL Repo
  • Remove not needed dependencies from this repository (mainly XText)
  • Document in CrySL Repository how to use the RulesetReader and obtain the Ruleset from a directory or Zip file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants