Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev : Use a fixed version of py-spiffe version in Dockerfiles #6

Open
telliere opened this issue Mar 22, 2024 · 2 comments
Open

Dev : Use a fixed version of py-spiffe version in Dockerfiles #6

telliere opened this issue Mar 22, 2024 · 2 comments

Comments

@telliere
Copy link
Collaborator

pyspiffe library was updated earlier today, the update being not transparent API talking, it caused my code to be broken (SpiffeID object creation, workload_api usage ...) because my development environment hasn't been updated but the version of the package in the Dockerfiles isn't fixed.

We should fix this behaviour by selecting a version while running pip install of pyspiffe in the Dockerfiles

Although, the update is great and pyspiffe now supports fetching multiple SVIDs, thing that wasn't the case and that we had to workaround.

@telliere telliere changed the title Dev : Fix py-spiffe version in Dockerfiles Dev : Use a fixed version of py-spiffe version in Dockerfiles Mar 22, 2024
telliere added a commit that referenced this issue Mar 25, 2024
telliere added a commit that referenced this issue Mar 25, 2024
@telliere
Copy link
Collaborator Author

telliere commented Mar 25, 2024

pyspiffe is under changes in order to be pushed to PyPi (see HewlettPackard/py-spiffe#133)
For this reason, a temporary solution is to fix the version used to a commit that we know worked (that has the setup.py ...)

@telliere
Copy link
Collaborator Author

telliere commented Apr 3, 2024

pyspiffe now released under Pypi : https://pypi.org/project/spiffe/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant