Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: _prep_inputs_for_prediction_and_return_scores to become public interface point #1607

Open
fkiraly opened this issue Apr 21, 2024 · 1 comment

Comments

@fkiraly
Copy link

fkiraly commented Apr 21, 2024

The AFT models are neat, though there does not seem to be a public interface point from which the paramters of the predictive (parametric) distributions could be queried.

I request that the current private interface point for this, _prep_inputs_for_prediction_and_return_scores, become public, perhaps with:

  • a clearer name, such as predict_proba_params
  • a unified return, e.g., returning a dict with {"paramname": paramvalue} format
@fkiraly
Copy link
Author

fkiraly commented Apr 21, 2024

I would be happy to contribute this, if you think this is a good idea, @CamDavidsonPilon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant