From 2403a58609099a55d1ce4c278272ca05741199fa Mon Sep 17 00:00:00 2001 From: Lokesh-Ramina Date: Thu, 20 Jun 2024 19:05:44 -0700 Subject: [PATCH] CommonDefaults: CPN OUT_BLH_MASK 1 A value of 3 means "query OUT1 and OUT2 for telemetry". The new APD firmware sends telemetry always, without waiting for a query. This meant that both OUT1 and OUT2 were showing active telemetry, despite the fact that OUT2 is disabled in the configuration. This caused errant duplicate esc.Status packets that toggled between an index of `motor_index` and 1. This was causing the second ESCs telemetry to get clobbered with all the other ESCs data in the log. SW-259 --- .../hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M1.parm | 2 +- .../hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M2.parm | 2 +- .../hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M3.parm | 2 +- .../hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M4.parm | 2 +- .../hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M5.parm | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M1.parm b/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M1.parm index 2036ebea51..99d5775e1f 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M1.parm +++ b/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M1.parm @@ -4,7 +4,7 @@ OUT1_MAX 2000 OUT1_TRIM 1000 OUT1_FUNCTION 33 OUT2_FUNCTION 0 -OUT_BLH_MASK 3 +OUT_BLH_MASK 1 OUT_BLH_OTYPE 6 OUT_BLH_POLES 28 OUT_BLH_EXTLM 1 diff --git a/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M2.parm b/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M2.parm index 7f9c2193ce..16f22cd2d8 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M2.parm +++ b/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M2.parm @@ -4,7 +4,7 @@ OUT1_MAX 2000 OUT1_TRIM 1000 OUT1_FUNCTION 34 OUT2_FUNCTION 0 -OUT_BLH_MASK 3 +OUT_BLH_MASK 1 OUT_BLH_OTYPE 6 OUT_BLH_POLES 28 OUT_BLH_EXTLM 1 diff --git a/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M3.parm b/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M3.parm index af91360a5f..51392e5819 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M3.parm +++ b/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M3.parm @@ -4,7 +4,7 @@ OUT1_MAX 2000 OUT1_TRIM 1000 OUT1_FUNCTION 35 OUT2_FUNCTION 0 -OUT_BLH_MASK 3 +OUT_BLH_MASK 1 OUT_BLH_OTYPE 6 OUT_BLH_POLES 28 OUT_BLH_EXTLM 1 diff --git a/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M4.parm b/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M4.parm index e923709e29..2b6b340bd5 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M4.parm +++ b/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M4.parm @@ -4,7 +4,7 @@ OUT1_MAX 2000 OUT1_TRIM 1000 OUT1_FUNCTION 36 OUT2_FUNCTION 0 -OUT_BLH_MASK 3 +OUT_BLH_MASK 1 OUT_BLH_OTYPE 6 OUT_BLH_POLES 28 OUT_BLH_EXTLM 1 diff --git a/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M5.parm b/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M5.parm index 4c8f9bd33a..c302a1ce7e 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M5.parm +++ b/libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M5.parm @@ -4,7 +4,7 @@ OUT1_MAX 2000 OUT1_TRIM 1000 OUT1_FUNCTION 37 OUT2_FUNCTION 0 -OUT_BLH_MASK 3 +OUT_BLH_MASK 1 OUT_BLH_OTYPE 6 OUT_BLH_POLES 28 OUT_BLH_EXTLM 0