Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The script doesn't allow to have the container name different to the node name #21

Open
alexdupre opened this issue Sep 9, 2022 · 1 comment

Comments

@alexdupre
Copy link

While it may be useful to set both to the same value by default, the script should allow to set them to two different values, given that they have different purposes and formats.

Currently the script uses the same NAME variable for both, so the container name set via -n command line argument is actually replaced by what it's set into the env/* configuration file.

@piotrMocz
Copy link
Collaborator

Alright, that makes sense. We actually had two different parameters for the node name and container name but I decided to simplify it.

However, with the next update of this repo I’ll keep the default value of the container name to be the same as the node name but re-introduce container name as a separate, optional argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants