Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule-17 examples inversed? #33

Open
yadimon opened this issue Feb 5, 2017 · 2 comments
Open

Rule-17 examples inversed? #33

yadimon opened this issue Feb 5, 2017 · 2 comments
Assignees

Comments

@yadimon
Copy link
Contributor

yadimon commented Feb 5, 2017

rule 17 says: Declare functions for operations that require more that one step
but the avoid examples has such function, and recomended makes the step directly with additional complexity.

so avoid and recomended should be switched

yadimon added a commit to yadimon/protractor-styleguide that referenced this issue Feb 5, 2017
@robinj robinj closed this as completed Mar 8, 2017
@CarmenPopoviciu
Copy link
Owner

The rule says Declare functions for operations that require more that one step. In that example, the function contained just one step, thus making it redundant to add an extra wrapper function. I don't see how the example was incorrect.

Withe these changes, the recommended example goes against the statement of the rule

@robinj robinj self-assigned this Mar 10, 2017
@yadimon
Copy link
Contributor Author

yadimon commented Mar 19, 2017

One line may be more then 1 step.
user.name.sendKeys('TeddyB'); means select name field, and send keys parameter
its like 2 steps.
For example if the logic : input name, will be more complex (name in form is not a good example, but let say is will be more complex somehow), you will need to change all places where you used this 'double step' line. With a special function for the logic its just a function content change.

btw. the function enterName should return the statement, in case the user of such function want to use promises etc.

and even if my PR were wrong, then the rule description should be like dont use function for one line code. Because it is what the code shows. Use function for more than one step is not represented in the example. So its probably just inverted and my PR is right :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants