Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer cache error handling #496

Open
rochoa opened this issue Sep 2, 2016 · 0 comments
Open

Renderer cache error handling #496

rochoa opened this issue Sep 2, 2016 · 0 comments

Comments

@rochoa
Copy link
Contributor

rochoa commented Sep 2, 2016

cacheEntry.on('error', function(err) {
debug("Removing RendererCache " + key + " on error " + err);
self.emit('err', err);
self.del(key);
});

Any error on a renderer drops the renderer from the cache. As a general approach it feels really good, as you start with a clean slate, however, recreating the renderer might be an expensive operation.

There are two potential alternatives here:

  • Allow to set what kind of errors should drop/recreate the renderer.
  • Improve renderer creation and keep this piece as it is: let it crash style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant