Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csn history giving wrong amounts of items sold #60

Open
ItsDed opened this issue Jan 27, 2022 · 1 comment
Open

csn history giving wrong amounts of items sold #60

ItsDed opened this issue Jan 27, 2022 · 1 comment

Comments

@ItsDed
Copy link

ItsDed commented Jan 27, 2022

CSN version: 1.3.3 build 51
server: git-purpur-1528 1.18.1

Tested with various common items like dirt, stone, mycelium etc, and it seems like a lot of blocks show the wrong amounts when checking history.

When selling 64 stone, the history would say 65. When selling 16 dirt, history would show 13. We've also encountered certain purchases not being displayed at all.

I haven't been able to pinpoint any pattern or cause, as its just happening at random.
@Phoenix616
Copy link
Member

Can you please check if those wrong amounts are also in the database.

Phoenix616 added a commit that referenced this issue Jan 28, 2022
@Phoenix616
Cleanup database handling
bc1a644 
This fixes a race condition where entries would go missing
 when a transaction happened while the batch was saving as
 the batch was cleared after saving.
This is fixed by polling a queue now.

Potentially related to #60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Phoenix616 @ItsDed