Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NATS library #6809

Open
TechnoBerry opened this issue Jan 9, 2024 · 8 comments · May be fixed by #7532
Open

Update NATS library #6809

TechnoBerry opened this issue Jan 9, 2024 · 8 comments · May be fixed by #7532
Assignees
@michaelstaib
Labels
Area: Subscriptions Issue is related to Subscriptions or a Subscription Provider ✋blocked The issue is blocked by an external dependency. 🌶️ hot chocolate

Comments

@TechnoBerry
Copy link

Product

Hot Chocolate

Is your feature request related to a problem?

HotChocolate.Subscriptions.Nats based on the library that is no longer maintained: https://github.com/Cysharp/AlterNats

The solution you'd like

It would be good to migrate HotChocolate.Subscriptions.Nats to the official NATS client: https://github.com/nats-io/nats.net.v2
@michaelstaib
Copy link
Member

Hey @TechnoBerry do you want to do a PR on this?

@glen-84
Copy link
Collaborator

glen-84 commented Jan 17, 2024

@oising FYI. 🙂

@oising
Copy link
Contributor

oising commented Jan 18, 2024 •
edited
Loading

@TechnoBerry I wouldn't update this just yet -- there's still a lot of churn going on with the 2.x NATS client, with breaking changes being introduced even with minor releases. I'd wait until 2.1 at least. They're on 2.1-preview3 at the moment.

While it's true that AlterNats is no longer being maintained (in fact, the NATS v2 client is a direct fork of AlterNats) - it is very stable.

/cc @michaelstaib

@glen-84 glen-84 added the Area: Subscriptions Issue is related to Subscriptions or a Subscription Provider label Jan 18, 2024
@TechnoBerry
Copy link
Author

A fair point. I think it really makes sense to wait for version 2.1.

@PascalSenn PascalSenn added the ✋blocked The issue is blocked by an external dependency. label Feb 14, 2024
@DDZ-DO
Copy link

DDZ-DO commented Jul 31, 2024

We are now on Version 2.3.2. Any chance of an update?

@PascalSenn
Copy link
Member

@oising Do you think an upgrade makes sense in the meantime?

@oising
Copy link
Contributor

oising commented Jul 31, 2024 •
edited
Loading

@oising Do you think an upgrade makes sense in the meantime?

I think a migration to the official SDK is probably due. I believe the 2.x client has had enough time to mature. I'm curious though if this is a blocker for anyone on the thread?

@PascalSenn
Copy link
Member

@TechnoBerry @DDZ-DO would either of you like to create a PR?

@michaelstaib michaelstaib self-assigned this Sep 2, 2024
@glen-84 glen-84 linked a pull request Sep 30, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelstaib michaelstaib

Labels
Area: Subscriptions Issue is related to Subscriptions or a Subscription Provider ✋blocked The issue is blocked by an external dependency. 🌶️ hot chocolate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated NATS library ChilliCream/graphql-platform
6 participants
@glen-84 @oising @TechnoBerry @michaelstaib @PascalSenn @DDZ-DO