Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid !important rules #11

Open
gagern opened this issue Aug 17, 2016 · 1 comment
Open

Avoid !important rules #11

gagern opened this issue Aug 17, 2016 · 1 comment
Assignees

Comments

@gagern
Copy link
Member

gagern commented Aug 17, 2016

Commit 33c1a76 added some !important rules to the CSS, but I don't think they should be neccessary and I think that having them will greatly reduce maintainability of the styling. Can we just drop them, or is there a particular reason we need them?

@gagern
Copy link
Member Author

gagern commented Aug 18, 2016

Apparently these rules mainly aim at making the examples from the source tree more visually appealing. I'd say we should do one of the following:

  1. restructure the examples in the repository to avoid that inline styling in the first place
  2. rewrite these examples on the fly while creating the website
  3. restrict these !important CSS rules to a file included with just these examples
  4. Restrict these rules to a selector only affecting these

That way cleaner parts of the layout will remain unaffected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants