INSER INTO and UPDATE SET fixed #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasHauck
requested changes
Dec 7, 2018
| $isString = false; | ||
| $stringStartedWith = null; | ||
|
|
||
| while (($char = substr($values, $stringOffset++, 1)) !== false) |
There was a problem hiding this comment.
We should try to do this in a more immutable way. Something like this:
$valuesArray = str_split($values);
$isString = false;
$stringStartedWith = null;
return array_reduce($valuesArray, function($dest, $value) use ($isString, $stringStartedWith) {
$stringStartedWith = static::isCharStringDelimiter($char, $stringStartedWith) && !$isString ? $value : null;
$isString = static::isCharStringDelimiter($char, $stringStartedWith) ? !$isString : $isString;
if (!$isString && $value === ',') return array_merge($dest, ['']);
if (!$isString && preg_match('/\s/', $value)) return $dest;
$currentKey = count($dest) - 1;
$newDest = $dest;
$newDest[$currentKey] .= $value;
return $newDest;
}, ['']);Maybe the code is broken somewhere, but it should nearly be working (hopefully :-D)
There was a problem hiding this comment.
You are right, your code is more immutable.
I would like to keep the while loop and not allocate memory for another copy of the values by using str_split.
It's against your code style, but is faster when dealing with bigger chunks of data.
|
Rest is awesome. Thank you! |
added 14 commits
September 19, 2019 18:07
and the use of ',' inside a string value
… modified testcase and excluded ANY whitespace character when Lexer is not in string mode
an unmatched string
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
INSERT INTO...due toarray_combine#44Proposed Changes
,with lexer that detects if the current value is a string and moves on to the next value when hitting a comma outside of a string.=character, introduced a limit on explode, the value can now be any string, including many many equal chars. There is a LIMIT! In case the column name contains = as a character it will not work.