Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional imports for gnmi.py not in 23.11 wheel file. #114

Open
miott opened this issue Dec 20, 2023 · 3 comments
Open

Conditional imports for gnmi.py not in 23.11 wheel file. #114

miott opened this issue Dec 20, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@miott
Copy link
Contributor

miott commented Dec 20, 2023

#110 release 23.11 was created. I assume that a yang.connector-23.11.whl file was supposed to be uploaded to pypi.org. #107 adding some conditional imports was committed 3 weeks prior to #110. Even though the conditional imports are correct in the repository, if I pip install yang.connector==23.11 the conditional imports are not there. It appears the wrong wheel file was uploaded to pypi.org.

@miott miott added the bug Something isn't working label Dec 20, 2023
@dwapstra
Copy link
Contributor

Since these are conditional imports, there is no dependency on them and hence the are not required to be installed and thus not added to setup.py.

Please clarify the expected behavior.

@miott
Copy link
Contributor Author

miott commented Dec 21, 2023

Since these are conditional imports, there is no dependency on them and hence the are not required to be installed and thus not added to setup.py.

Please clarify the expected behavior.

Looking closer at the git commit log, It looks like #107 probably did not get merged into master before the 23.11 release wheel was built and uploaded to pypi.org.
Screenshot 2023-12-21 at 8 27 01 AM

Since this commit did not get into the wheel, yangsuite fails install inside a pyats 23.11 environment.

When is the next release coming out? If it is not until February, please put out a special release soon. If the next release will be in January, we could just wait.

@domachad
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants