Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send command replies to direct messages #14

Open
Gjum opened this issue Nov 3, 2023 · 2 comments
Open

Send command replies to direct messages #14

Gjum opened this issue Nov 3, 2023 · 2 comments

Comments

@Gjum
Copy link

Gjum commented Nov 3, 2023

Currently, command replies (/ingame, /apitoken, etc.) are sent in the channel where the command is used, for anyone else to see. This often accidentally reveals private information (tokens, groups, etc.) of the command user. Example:
image

One solution is to send all replies to the user's DMs.

Alternatively, the reply message should have the ephemeral flag, so only the command user can see it, and it disappears when the Discord app is restarted. Example:
image

Another option, for commands where it is desired to show the reply to others in the channel, would be to first reply with a button interaction "Do you want to show the reply in the channel here? [show in channel] [show in DMs]", and only send the actual reply to the channel or DMs accordingly.

@tybug
Copy link

tybug commented Nov 13, 2023

I just want to throw out a consideration here, which is that Snitchvis uses the output of !kira relayconfig to parse snitch messages correctly (code). If !kira relayconfig was dm'd instead, this would be considerably less user-friendly to set on snitchvis1. Hopefully there will remain a way to send this information publicly.

Footnotes

  1. Not that it's very friendly right now, mind you, but running !kira relayconfig followed by .add-kira-config is bearable enough.

@Gjum
Copy link
Author

Gjum commented Nov 13, 2023

Yes, only potentially sensitive commands should go to DMs. Another example that should stay in the channel where it's used is /whoami, the response of which some bots read to easily link people's in-game and Discord accounts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Triage
Development

No branches or pull requests

2 participants