Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when running with PolyPatcher #205

Open
5 tasks done
mywar5 opened this issue Sep 13, 2024 · 10 comments
Open
5 tasks done

Error when running with PolyPatcher #205

mywar5 opened this issue Sep 13, 2024 · 10 comments

Comments

@mywar5
Copy link

mywar5 commented Sep 13, 2024

Your CleanroomMC Discord Username

mywar5

Cleanroom Version

0.2.3 #698

Java Version

Java 22

Graphics Card Vendor

NVidia

Bug Report

Cannot start game
just after latest issue,I tried this,but this is a new issue

minecraft-exported-logs-2024-09-13T23-10-40.log
crash-2024-09-13_23.10.25-client.txt

Mod List

fugue-0.16.3 The latest build
polypatcher-1.10.1
scalar-3.4.2

MMC Instance Notes

.

Final Checklist

  • I have searched the issues and haven't found a similar issue.
  • I have read the known incompatibilities and this is not related to one of those.
  • I have installed Fugue and it does not fix this issue.
  • I am using experimental branch and have installed Scalar and it does not fix this issue.
  • I am running a test build from Cleanroom Github Actions. (Or, if I've compiled it myself I plan to fix the issue)
@kappa-maintainer
Copy link
Collaborator

kappa-maintainer commented Sep 13, 2024

Add S:net.minecraft.client.Minecraft=field_175619_R to final fields patching list in fugue.cfg

@mywar5
Copy link
Author

mywar5 commented Sep 14, 2024

Add S:net.minecraft.client.Minecraft=field_175619_R to final fields patching list in fugue.cfg

it can't work

crash-2024-09-14_12.20.04-client.txt
minecraft-exported-logs-2024-09-14T12-20-15.log

@s0u7a
Copy link

s0u7a commented Sep 19, 2024

Same Issue

@s0u7a
Copy link

s0u7a commented Sep 21, 2024

I solved this error by rewriting /src/main/java/club/sk1er/patcher/mixins/performance /MinecraftMixin_ToggleGLErrorChecking.java in PolyPatcher. I did so. However, I get an error from cc.polyfrost.oneconfig.internal.plugin.hooks.Lwjgl2FunctionProvider on startup or when trying to view OneConfig, and it crashes when trying to view Oneconfig and crashes when trying to view Oneconfig.
PolyPatcher will work with Cleanroom once these issues are resolved (I heard this will be resolved in OneConfig v1, but development has stopped.)
Using Opticraft mods+PolyPatcher in Non-Cleanroom, I got very good FPS.
It would be great if the same could be done in Cleanroom.
Please let me know if there is anything I can do to help.
(I am Japanese and I use a translator)

@Rongmario Rongmario changed the title Cannot start game Error when running with PolyPatcher Sep 21, 2024
@Rongmario
Copy link
Member

@s0u7a can you send the log from when you fixed the issue? 問題を解決した時のログを送ってもらえますか?

@s0u7a
Copy link

s0u7a commented Sep 23, 2024

OK
https://mclo.gs/zk1oBYU

@Wyvest
Copy link

Wyvest commented Sep 23, 2024

I solved this error by rewriting /src/main/java/club/sk1er/patcher/mixins/performance /MinecraftMixin_ToggleGLErrorChecking.java in PolyPatcher. I did so. However, I get an error from cc.polyfrost.oneconfig.internal.plugin.hooks.Lwjgl2FunctionProvider on startup or when trying to view OneConfig, and it crashes when trying to view Oneconfig and crashes when trying to view Oneconfig. PolyPatcher will work with Cleanroom once these issues are resolved (I heard this will be resolved in OneConfig v1, but development has stopped.) Using Opticraft mods+PolyPatcher in Non-Cleanroom, I got very good FPS. It would be great if the same could be done in Cleanroom. Please let me know if there is anything I can do to help. (I am Japanese and I use a translator)

What changes did you make to that mixin?

@s0u7a
Copy link

s0u7a commented Sep 24, 2024

Delete /src/main/java/club/sk1er/patcher/mixins/performance/MinecraftMixin_ToggleGLErrorChecking.java
and Edit /src/main/resources/mixin.patcher.json(Delete ToggleGLErrorChecking line)
(At first I was going to replace it with a code to remove GL errors, but GLstateManager in the same directory has that functionality and I figured it would be better to remove it. there are many other mods that have the ability to remove GL errors.)

@mywar5
Copy link
Author

mywar5 commented Oct 1, 2024

I managed to get into the game through s0u7a‘s method, but I was hit by another problem--like this
image

@mywar5
Copy link
Author

mywar5 commented Oct 2, 2024

What's more,polypatcher and cleanroom are compatible with Optifine on their own, but not when they are put together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants