From 37db7c4b021c623273f6e24dd0455c87054316d4 Mon Sep 17 00:00:00 2001
From: mhkc <markus.johansson@me.com>
Date: Tue, 19 Mar 2024 11:33:40 +0100
Subject: [PATCH] removed sample id from sampleBase

---
 CHANGELOG.md         | 2 ++
 prp/models/sample.py | 2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5bdb808..a0d8f28 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### Changed
 
+ - Removed sample id from Sample object
+
 ## [0.5.0]
 
 ### Added
diff --git a/prp/models/sample.py b/prp/models/sample.py
index 6e80b4c..a90c83e 100644
--- a/prp/models/sample.py
+++ b/prp/models/sample.py
@@ -34,8 +34,6 @@ class MethodIndex(RWModel):
 
 class SampleBase(RWModel):
     """Base datamodel for sample data structure"""
-
-    sample_id: str = Field(..., alias="sampleId", min_length=3, max_length=100)
     run_metadata: RunMetadata = Field(..., alias="runMetadata")
     qc: List[QcMethodIndex] = Field(...)
     species_prediction: SpeciesPredictionResult = Field(..., alias="speciesPrediction")